Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): add missing method pkg/varlog.(*MockLog).AppendableLogStreams #487

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Jun 20, 2023

No description provided.

@ijsong
Copy link
Member Author

ijsong commented Jun 20, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.18 ⚠️

Comparison is base (cd48efe) 62.22% compared to head (7bf9bf9) 62.04%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #487      +/-   ##
==========================================
- Coverage   62.22%   62.04%   -0.18%     
==========================================
  Files         133      133              
  Lines       18490    18490              
==========================================
- Hits        11505    11473      -32     
- Misses       6414     6436      +22     
- Partials      571      581      +10     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ijsong ijsong marked this pull request as ready for review June 20, 2023 03:32
@ijsong ijsong requested a review from hungryjang as a code owner June 20, 2023 03:32
@ijsong
Copy link
Member Author

ijsong commented Jun 20, 2023

@ijsong started a stack merge that includes this pull request via Graphite.

@ijsong ijsong merged commit 61747ed into main Jun 20, 2023
@ijsong ijsong deleted the fix_missing_mock_appendable_logstreams branch June 20, 2023 04:24
@ijsong
Copy link
Member Author

ijsong commented Jun 20, 2023

@ijsong merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants