From 49a09ae904532999d2f3f4bacad47d9efab2c90d Mon Sep 17 00:00:00 2001 From: Kaijie Chen Date: Wed, 27 Dec 2023 10:48:55 +0800 Subject: [PATCH] Revert "Revert "[feature](load) enable memtable on sink node by default (#28963)" (#29090)" This reverts commit f6850f8cdbdf9d1669e844d93664c81ff9fcd32c. --- docs/en/docs/advanced/variables.md | 2 +- docs/zh-CN/docs/advanced/variables.md | 2 +- .../src/main/java/org/apache/doris/qe/SessionVariable.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/en/docs/advanced/variables.md b/docs/en/docs/advanced/variables.md index 030e228f5234aae..e339b1893dc789d 100644 --- a/docs/en/docs/advanced/variables.md +++ b/docs/en/docs/advanced/variables.md @@ -689,7 +689,7 @@ Note that the comment must start with /*+ and can only follow the SELECT. * `enable_memtable_on_sink_node` - Whether to enable MemTable on DataSink node when loading data, default is false. + Whether to enable MemTable on DataSink node when loading data, default is true. Build MemTable on DataSink node, and send segments to other backends through brpc streaming. diff --git a/docs/zh-CN/docs/advanced/variables.md b/docs/zh-CN/docs/advanced/variables.md index 2a697b01bf7de49..510ad85c36e9ff1 100644 --- a/docs/zh-CN/docs/advanced/variables.md +++ b/docs/zh-CN/docs/advanced/variables.md @@ -677,7 +677,7 @@ try (Connection conn = DriverManager.getConnection("jdbc:mysql://127.0.0.1:9030/ * `enable_memtable_on_sink_node` - 是否在数据导入中启用 MemTable 前移，默认为 false + 是否在数据导入中启用 MemTable 前移，默认为 true 在 DataSink 节点上构建 MemTable，并通过 brpc streaming 发送 segment 到其他 BE。 diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java b/fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java index d594fd395e772ff..b908b0cede21915 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java +++ b/fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java @@ -1343,7 +1343,7 @@ public void setEnableLeftZigZag(boolean enableLeftZigZag) { public boolean truncateCharOrVarcharColumns = false; @VariableMgr.VarAttr(name = ENABLE_MEMTABLE_ON_SINK_NODE, needForward = true) - public boolean enableMemtableOnSinkNode = false; + public boolean enableMemtableOnSinkNode = true; @VariableMgr.VarAttr(name = LOAD_STREAM_PER_NODE) public int loadStreamPerNode = 60;