Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Custom query params are not stored in a separate object #37

Merged
merged 2 commits into from
Sep 2, 2016

Conversation

roonyh
Copy link
Contributor

@roonyh roonyh commented Aug 30, 2016

They will be directly stored in the url just like other known query params. This also makes extra checking for other unknown query params not needed. They will also be added to state as custom query params.

They will be directly stored in the url just like other known query params. This also makes extra checking for other unknown query params not needed. They will also be added to state as custom query params.
@roonyh roonyh force-pushed the custom-query-params-directly-in-url branch from 1aaee5f to 8fdf22f Compare August 30, 2016 11:27
Custom params are spread before core params.
@arunoda arunoda merged commit 9dba9d9 into master Sep 2, 2016
@arunoda arunoda deleted the custom-query-params-directly-in-url branch September 2, 2016 01:09
ndelangen pushed a commit that referenced this pull request Apr 2, 2017
ndelangen pushed a commit that referenced this pull request Apr 2, 2017
Test regex for the whole path instead of just the filename
ndelangen pushed a commit that referenced this pull request Apr 10, 2017
Make a description optional
ndelangen pushed a commit that referenced this pull request Apr 10, 2017
Fix typo - Button should be button
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants