Add support for 'jsx' extensions #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's fairly common for people having '.jsx' extensions for their react components.
| @@ -29,7 +29,7 @@ const config = { | |||
| module: { | |||
| loaders: [ | |||
| { | |||
| test: /\.js$/, | |||
| test: /\.jsx?$/, | |||
There was a problem hiding this comment.
I hope we need to add .js as well. Does this support it as well?
There was a problem hiding this comment.
This regex will match both .js and .jsx. The ? makes the x optional.
There was a problem hiding this comment.
Yes. As said by @levithomason, this pattern optionally matches the last letter "x". So it matches both ".js" and ".jsx"
There was a problem hiding this comment.
Super. Didn't read that. Thanks guys.
ndelangen
pushed a commit
that referenced
this pull request
Apr 5, 2017
Ability to dock action logger in right
ndelangen
pushed a commit
that referenced
this pull request
Apr 5, 2017
Add more tests for KnobManager
ndelangen
pushed a commit
that referenced
this pull request
Apr 5, 2017
ndelangen
pushed a commit
that referenced
this pull request
Apr 5, 2017
fixes #18 : create react app public directory
ndelangen
pushed a commit
that referenced
this pull request
Apr 11, 2017
Refactor the datastore to make further improvements.
ndelangen
pushed a commit
that referenced
this pull request
Feb 23, 2024
Implement bare minimum modal component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's fairly common for people having '.jsx' extensions for their react components.