Move UI testing libraries to devDependencies #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes. you are right. |
|
This got merged, but do you know when the next release will be? I have a project using |
|
Within today or tomorrow. This our top priority. |
This was referenced Feb 1, 2020
This was referenced Sep 15, 2021
This was referenced Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
react-addons-test-utils@^15.0.1in the normal dependencies is creating a peerDependency of `react@^15.0.0, which is breaking my React 0.14 build when I try to run shrinkwrap.As far as i can tell these are only used internally to test the storybook UI. Unless I'm mistaken it makes sense for these to got into devDependencies.