Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add airbnb-js-shims to client-side JS #147

Merged
merged 1 commit into from
Apr 26, 2016

Conversation

wyattdanger
Copy link
Contributor

@wyattdanger wyattdanger commented Apr 25, 2016

This adds airbnb-js-shims to the admin js and the iframe js, which gets IE11 working for me, where it used to break on an Array.from

@wyattdanger wyattdanger force-pushed the swb--add-js-shims branch 2 times, most recently from e582598 to 0a5f3d4 Compare April 25, 2016 21:58
@arunoda
Copy link
Member

arunoda commented Apr 25, 2016

Isn't this something babel does automatically? I like to know which code breaks this?
Babel load it from the corejs package.

Could you try updating core-js to the latest: 2.2.3 in your project and see whether it fixes this or not.

@ljharb
Copy link
Contributor

ljharb commented Apr 26, 2016

Babel transpiles syntax, not API. Shims are still required, and these ones actively shim fewer things than babel-polyfill/core-js.

@arunoda
Copy link
Member

arunoda commented Apr 26, 2016

@ljharb doen't add more overhead. I think we only need es6 shims in that case.
So, it seems like babel's core-js usage has a problem. So we may should open an issue on core-js repo.

In the meantime, let's add only es6-shim to the core.

@ljharb
Copy link
Contributor

ljharb commented Apr 26, 2016

@arunoda es5-shim and es5-sham are still required for React to work in IE 8. No browser, even latest Chrome, complies with ES5, even.

@arunoda
Copy link
Member

arunoda commented Apr 26, 2016

@ljharb I'm not sure whether we need to support browsers like IE8

No browser, even latest Chrome, complies with ES5, even.
What do you mean by this?

CC / @mnmtanish

@ljharb
Copy link
Contributor

ljharb commented Apr 26, 2016

@arunoda the cost is tiny, and the benefits range from zero to very high, depending on users' browser support matrix.

As for ES5, there does not exist any version of any JS engine that fully complies with ES5. The failures are minimal at this point, but they exist, and using the shims ensures they are papered over.

@arunoda
Copy link
Member

arunoda commented Apr 26, 2016

@ljharb I think we can go with this.
I'll take this.

This gets IE11 working for me
@wyattdanger
Copy link
Contributor Author

Rebased, conflicts resolved

@arunoda
Copy link
Member

arunoda commented Apr 26, 2016

Awesome.

@arunoda arunoda merged commit c0b49ad into storybookjs:master Apr 26, 2016
@shilman shilman added the misc label May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants