Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax highlighting in action logger #118

Merged
merged 4 commits into from
Apr 19, 2016
Merged

syntax highlighting in action logger #118

merged 4 commits into from
Apr 19, 2016

Conversation

ritz078
Copy link
Contributor

@ritz078 ritz078 commented Apr 18, 2016

screen shot 2016-04-19 at 12 27 56 am

screen shot 2016-04-19 at 12 28 12 am

@@ -25,7 +25,7 @@ describe('<Foldable />', function () {
args: 'things',
};

const fullString = '{\n "name": "test action",\n "args": "things"\n}';
const fullString = '{\n name: "test action",\n args: "things"\n}';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we write an additional test case targetted for syntax highlighting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@arunoda
Copy link
Member

arunoda commented Apr 19, 2016

Overall, this looks cool.
Once we are okay with suggestions I made, we could take this in.

@ritz078
Copy link
Contributor Author

ritz078 commented Apr 19, 2016

@arunoda added tests and comment

@arunoda
Copy link
Member

arunoda commented Apr 19, 2016

Okay. Great.

@arunoda arunoda merged commit efd329a into storybookjs:master Apr 19, 2016
@arunoda
Copy link
Member

arunoda commented Apr 19, 2016

Published as v1.14.0

wyattdanger pushed a commit to wyattdanger/react-storybook that referenced this pull request Apr 26, 2016
* feat(highlight):added syntax highlighting in the action logger

* fix lint error

* fixed tests

* added tests for highlight
@shilman shilman added the misc label May 27, 2017
Copy link

nx-cloud bot commented May 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3e2d64f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants