Skip to content
This repository has been archived by the owner on Jan 17, 2022. It is now read-only.

fix(server): Add setting for "package_max_length" #96

Merged
merged 1 commit into from
Dec 19, 2019
Merged

fix(server): Add setting for "package_max_length" #96

merged 1 commit into from
Dec 19, 2019

Conversation

fjogeleit
Copy link
Contributor

@fjogeleit fjogeleit commented Dec 18, 2019

I need this option to configure the max file size for uploads

@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #96 into develop will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #96      +/-   ##
=============================================
+ Coverage      87.19%   87.24%   +0.04%     
- Complexity       602      603       +1     
=============================================
  Files             84       84              
  Lines           1843     1850       +7     
=============================================
+ Hits            1607     1614       +7     
  Misses           236      236
Impacted Files Coverage Δ Complexity Δ
...mfony/Bundle/DependencyInjection/Configuration.php 97.79% <100%> (+0.03%) 7 <0> (ø) ⬇️
src/Server/HttpServerConfiguration.php 92.37% <100%> (+0.26%) 55 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75e7f23...3942043. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented Dec 19, 2019

Code Climate has analyzed commit 3942043 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Clarity 1

Note: there is 1 critical issue.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 87.2% (0.0% change).

View more on Code Climate.

@k911 k911 merged commit 37758f2 into k911:develop Dec 19, 2019
@fjogeleit
Copy link
Contributor Author

Thanks for help

@k911
Copy link
Owner

k911 commented Dec 19, 2019

@fjogeleit Thank you for your contribution, I'll release that ASAP

k911 added a commit that referenced this pull request Dec 19, 2019
* fix(server): Add missing setting for "package_max_length" (#96) ([37758f2](37758f2)), closes [#96](#96)
* chore(php): Support php 7.4 (#94) ([75e7f23](75e7f23)), closes [#94](#94)
* build(deps-dev): bump phpunit/phpunit from 8.4.3 to 8.5.0 (#92) ([02d10a9](02d10a9)), closes [#92](#92)
@k911 k911 changed the title feat(server): Add setting for "package_max_length" fix(server): Add setting for "package_max_length" Dec 20, 2019
@k911 k911 added kind/bug/fixed and removed kind/feature New feature or request labels Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants