This repository has been archived by the owner on Jan 17, 2022. It is now read-only.
fix(static-server): Fix unset public dir path in "AdvancedStaticFilesServer" #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k911
added
area/http-server
kind/bug/confirmed
…Server" A bug caused that "AdvancedStaticFilesServer" was not tagged as bootable service, what resulted in unsed public directory path.
k911
force-pushed
the
fix/static-files-serving
branch
from
3d2b317 to
17efbc1
Compare
|
Code Climate has analyzed commit 17efbc1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 83.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 84.9% (0.8% change). View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## develop #52 +/- ##
=============================================
+ Coverage 83.82% 84.55% +0.73%
- Complexity 463 464 +1
=============================================
Files 67 67
Lines 1434 1431 -3
=============================================
+ Hits 1202 1210 +8
+ Misses 232 221 -11
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug caused that "AdvancedStaticFilesServer" was not tagged as bootable service, what resulted in
unsed public directory path.