This repository has been archived by the owner on Jan 17, 2022. It is now read-only.
feat(response-processor): hiding Swoole StreamedResponse support from Symfony #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #509 +/- ##
=============================================
+ Coverage 85.61% 86.06% +0.45%
- Complexity 661 663 +2
=============================================
Files 97 97
Lines 2078 2089 +11
=============================================
+ Hits 1779 1798 +19
+ Misses 299 291 -8
|
Rastusik
force-pushed
the
platform_idenpendent_streamed_response_processing
branch
from
c132552 to
388c400
Compare
Rastusik
force-pushed
the
platform_idenpendent_streamed_response_processing
branch
from
388c400 to
371e54a
Compare
|
@Rastusik good work here, tomorrow I'll debug why some tests are failing here, probably unrelated to these changes |
|
Code Climate has analyzed commit 371e54a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 97.1% (50% is the threshold). This pull request will bring the total coverage in the repository to 86.1% (0.5% change). View more on Code Climate. |
swoole-bundle-bot
added a commit
that referenced
this pull request
May 5, 2021
* ci: remove php 74 latest from build ([3e4c8f1](3e4c8f1)) * ci(docker): upgrade images used as dependencies ([8793695](8793695)) * chore(composer): lock php-cs-fixer to ^2.19.0 ([9e40296](9e40296)) * chore(composer): upgrade dependencies ([903e484](903e484)) * chore(deps): upgrade deps ([4718a82](4718a82)) * chore(docker): upgrade dependencies ([27393f8](27393f8)) * feat(response-processor): hiding Swoole StreamedResponse support from Symfony (#509) ([ebe8077](ebe8077)), closes [#509](#509)
This was referenced May 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation according to this conversation: #300 (comment)