Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LeaderElection accessible #526

Closed
kuritka opened this issue Jun 16, 2021 · 2 comments
Closed

Make LeaderElection accessible #526

kuritka opened this issue Jun 16, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@kuritka
Copy link
Collaborator

kuritka commented Jun 16, 2021

The LeaderElection controller property is hardcoded. Currently set to false.

  • Make LeaderElection accessible via environment variable (and if necessary, provide another implementation to make the leader election work)
  • Provide tests to prove that the leaderelection mechanism works
	mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
		Scheme:             runtimescheme,
		MetricsBindAddress: config.MetricsAddress,
		Port:               9443,
		LeaderElection:     false, // <---- config.LeaderElection
		LeaderElectionID:   "8020e9ff.absa.oss",
	})
@kuritka kuritka added the enhancement New feature or request label Jun 16, 2021
@ytsarev
Copy link
Member

ytsarev commented Jun 16, 2021

elastic/cloud-on-k8s#3632 (comment) might relevant

@ytsarev ytsarev added this to the 1.0 milestone Aug 9, 2021
@somaritane
Copy link
Contributor

Parking this one.

@somaritane somaritane removed this from the 1.0 milestone Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants