-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent node IP not replaced with Tailscale VPN IP #10064
Comments
After some more digging, using |
Thanks for the report! You are totally correct and there is a bug. I have just created a PR to address it and fix it |
Thanks @manuelbuil! I would try to fix this myself if possible might take some more time than usual but I'd be interested in contributing. I am not really sure how to approach local development though. |
Oh sorry! I have already created a fix this morning :( ==> #10074 |
If you'd like to help, there is one thing you could certainly do. Enhance our tailscale e2e testcase with one extra node which uses Right now we are deploying both server and worker nodes with |
I would definitely attempt to implement this! If I get this right the Vagrant sets up multiple VMs which act as nodes in the cluster and the tests are then run on these? I am currently away so will attempt work on this next week! Thank you very much for your help looking forward to contributing! |
Correct. You run the test by executing |
##Environment Details Infrastructure
Node(s) CPU architecture, OS, and version: Linux 5.14.21-150500.53-default x86_64 GNU/Linux Config.yaml:
Reproduction
Results: Showing on existing release v1.30.1+k3s1 that the tailscale ip is not used when starting up agents. $ kgn -o wide
Same cluster but a newer agent running the latest commit_id for branch attention on node 1-1-1-13 also showing the commit_id version f2e7c01 $ kgn -o wide
|
Environmental Info:
K3s Version:
Node(s) CPU architecture, OS, and Version:
Cluster Configuration:
Describe the bug:
Adding nodes using
--vpn-auth-file
only changes the IP address of the server node and does not update thenode-ip
to reflect the one in Tailscale.Steps To Reproduce:
k3s
on server node withcurl -sfL https://get.k3s.io | sh -s - --disable servicelb --disable traefik --vpn-auth-file /home/terminator/vpn-auth-file
k3s
on agent node withcurl -sfL https://get.k3s.io | K3S_URL=$URL K3S_TOKEN=$TOKEN sh -s - --vpn-auth-file /home/terminator/vpn-auth-file
Expected behavior:
Expected behaviour should be that
drone-one
IP should match the one in Tailscale and not the one from the local network.Actual behavior:
Additional context / logs:
Here are some logs when running
Whereas on the
server
the IP address is correctly updated to match the one from TailscaleI remember this working fine on 1.27 but I am not sure if I run anything different to be honest so I can try that and update the issue here. Could someone also point me to how I can develop
k3s
in order to contribute? I would really appreciate any help on this.Thank you for such an amazing tool with so many frequent updates!
The text was updated successfully, but these errors were encountered: