Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Ability to delete a term from reading screen. #13

Closed
disfated opened this issue Oct 6, 2023 · 3 comments
Closed

[Feature] Ability to delete a term from reading screen. #13

disfated opened this issue Oct 6, 2023 · 3 comments
Labels
fixed Fixed in develop or master, to be launched.

Comments

@disfated
Copy link

disfated commented Oct 6, 2023

It is occasionally needed to be able to remove a term while staying on the reading page.
@jzohrab jzohrab transferred this issue from jzohrab/lute Nov 11, 2023
@jzohrab jzohrab added this to Lute-v3 Nov 28, 2023
@jzohrab
Copy link
Collaborator

jzohrab commented Dec 15, 2023

Just adding a "delete" button next to the "Save" button would suffice as a first pass:

Image

A few caveats:

  • if reading, this should trigger a page reload so that all of the parsed tokens are rendered correctly
  • if on the term form, this should redirect to the term listing
  • should show a warning that this can't be undone. In particular, if a term has children, those will be orphaned and any parent description will be lost. Perhaps an extra warning for parents would be good.

dgc08 added a commit to dgc08/lute-v3 that referenced this issue Dec 28, 2023
@dgc08
Fix issue LuteOrg#13: Ability to delete a term from reading screen
4f0687c 
Added Delete button in term form, visible in both /read and /term/edit:
 Button in /read reloads the page
 Button in /term/edit redirects to /term/index

Removed old delete button in /term/edit
@jzohrab
Copy link
Collaborator

jzohrab commented Dec 29, 2023

Fixed in #85 , merged into develop.

@jzohrab jzohrab moved this to In Progress in Lute-v3 Dec 29, 2023
@jzohrab jzohrab added the fixed Fixed in develop or master, to be launched. label Dec 29, 2023
@jzohrab
Copy link
Collaborator

jzohrab commented Jan 4, 2024

Launch in 3.0.9.

@jzohrab jzohrab closed this as completed Jan 4, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Lute-v3 Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed Fixed in develop or master, to be launched.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@disfated @jzohrab