Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace duplicate code with a global environment variable #799

Closed
70825 opened this issue Aug 21, 2023 · 1 comment · Fixed by #800
Closed

Replace duplicate code with a global environment variable #799

70825 opened this issue Aug 21, 2023 · 1 comment · Fixed by #800

Comments

@70825
Copy link
Contributor

70825 commented Aug 21, 2023

Is your feature request related to a problem? Please describe.

I find duplicate code and it seems like it can be refactored to eliminate the redundancy.

Describe the solution you'd like

All jobs are using the same value for the MVN_CMD environment variable in ci.yml

So I think it would be better to use a global environment variable

[AS-IS]

jobs:
  oracle:
    env:
      MVN_CMD: ./mvnw --no-transfer-progress -B
  temurin:
    env:
      MVN_CMD: ./mvnw --no-transfer-progress -B
  ...

[TO-BE]

env:
  MVN_CMD: ./mvnw --no-transfer-progress -B

...

Describe alternatives you've considered

x

Additional context

If you want this changed, can I try this issue?

I've always wanted to contribute directly to the JWT library that I've been using 😀

@lhazlewood
Copy link
Contributor

Thanks for the issue! If you'd like to open a pull request, and the build works, I'd be happy to include your improvement :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants