Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

done is not a function in jest-preset-angular 8.0.0 #697

Closed
jankeesvanandel opened this issue Mar 17, 2020 · 5 comments · Fixed by #698
Closed

done is not a function in jest-preset-angular 8.0.0 #697

jankeesvanandel opened this issue Mar 17, 2020 · 5 comments · Fixed by #698
Labels
bug Something isn't working builders:jest

Comments

@jankeesvanandel
Copy link
Contributor

Describe the Bug

I get "done is not a function" errors when I pass in a done callback. This is caused by the following bug in jest-preset-angular: thymikee/jest-preset-angular#357

I upgraded my local version of jest-preset-angular, but @angular-builders/jest is still using the 8.0.0 version, which has the issue.

I replaced the node_modules/@angular-builders/jest/node_modules/jest-preset-angular with the new 8.1.2 version and with that version everything works, but I have no "proper" way to override the dependency version.

Could you please upgrade to 8.1.2?

Environment


Libs
- @angular/core version: 9.0.4
- @angular-devkit/build-angular version: ~0.900.4
- @angular-builders/jest version: 9.0.0

For Tooling issues:
- Node version: v13.8.0
- Platform:  Mac
@just-jeb
Copy link
Owner

Sure. Would you like to make a PR?

@just-jeb just-jeb added bug Something isn't working builders:jest labels Mar 17, 2020
@jankeesvanandel
Copy link
Contributor Author

done! #698

@just-jeb
Copy link
Owner

just-jeb commented Mar 17, 2020

The fix should be available in the next beta build within a few minutes (I think it should be @angular-builders/jest@9.0.2-beta).

@just-jeb
Copy link
Owner

Update: it's fixed in @angular-builders/jest@9.0.1-beta.1

@jankeesvanandel
Copy link
Contributor Author

Awesome! Thanks for the quick action!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builders:jest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants