Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote on Mermaid graph renderer for Markdown cells #208

Closed
20 of 63 tasks
fcollonval opened this issue Aug 3, 2023 · 3 comments
Closed
20 of 63 tasks

Vote on Mermaid graph renderer for Markdown cells #208

fcollonval opened this issue Aug 3, 2023 · 3 comments
Labels
decision made vote

Comments

@fcollonval
Copy link
Member

fcollonval commented Aug 3, 2023 •
edited by ohrely
Loading

At the July 26th meeting, it was decided to call for a vote on adding support to render mermaid JS code block as graph in Markdown cells: jupyterlab/jupyterlab#14102

FYI there is a related JEP opened: jupyter/enhancement-proposals#101 - that will probably not make it. This means the standard will not require mermaid JS code block to be rendered as graph by notebook clients. But notebook clients can add that feature as it does not impact the notebook format used.

The vote will be closed on August 20th at midnight anywhere on earth (or as soon as we reach majority).

The question: Should we render mermaid JS code block as graph in Markdown cells?

The vote:
@afshin afshin added the vote label Aug 3, 2023
@fperez
Copy link

fperez commented Aug 3, 2023

As a reference, MyST tools are being updated to match this, so we have good convergence of the approaches. Ultimately this will mean that both the live in-notebook experience and any export made by MyST will give users a consistent experience.

Thx to @rowanc1 for the work on the MyST side.

@ellisonbg
Copy link
Contributor

@fperez thanks for the details about MyST, that helps.

@fcollonval fcollonval mentioned this issue Aug 10, 2023
Closed
@echarles echarles mentioned this issue Aug 15, 2023
Closed
@fcollonval
Copy link
Member Author

This vote passes with 15 Yes / 1 No / 1 Abstain with the quorum reached as 17 votes out of 21 members expressed their voice.

I'm gonna help Nick merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
decision made vote
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ellisonbg @fperez @afshin @fcollonval