From 8cac1059db0af4bd8afe09190e8f444f1c4f9977 Mon Sep 17 00:00:00 2001 From: Steven Silvester Date: Thu, 10 Nov 2022 20:05:48 -0600 Subject: [PATCH 1/3] add package download args option --- .github/actions/downstream-test/action.yml | 7 ++++++- .github/workflows/tests.yml | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/actions/downstream-test/action.yml b/.github/actions/downstream-test/action.yml index 8e9c3ec..14bc16b 100644 --- a/.github/actions/downstream-test/action.yml +++ b/.github/actions/downstream-test/action.yml @@ -8,6 +8,10 @@ inputs: description: "The package spec to install" default: '."[test]"' required: true + package_download_args: + description: "The arguments used to download the package" + required: true + default: "--no-deps --no-binary" test_command: description: "The test command" default: "pytest -vv -raXxs --durations 10 --color=yes" @@ -28,6 +32,7 @@ runs: package_name=${{inputs.package_name}} package_spec="${{inputs.package_spec}}" test_command="${{inputs.test_command}}" + package_download_args="${{inputs.package_download_args}}" root=$(pwd) eval "${{inputs.env_values}}" echo "::endgroup::" @@ -43,7 +48,7 @@ runs: echo "::group::Download and extract the sdist" mkdir downstream_test cd downstream_test - pip download --no-deps --no-binary ${package_name} ${package_name} + pip download ${package_download_args} ${package_name} ${package_name} mkdir ${package_name} tar xfz *.tar.gz -C ${package_name} --strip-components 1 cd ${package_name} diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 17883f3..a768528 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -64,6 +64,7 @@ jobs: with: package_name: nbclient package_spec: "nbclient[test] ipykernel" + package_download_args: "--no-deps --no-binary --use-pep517" test_command: "echo 'hello'" extra_test: "pytest --pyargs nbclient" env_values: IPYKERNEL_CELL_NAME=\ From 52ebd61de1ed0f887d9049bf2a8c77351747ae4a Mon Sep 17 00:00:00 2001 From: Steven Silvester Date: Thu, 10 Nov 2022 20:16:08 -0600 Subject: [PATCH 2/3] fix args handling --- .github/actions/downstream-test/action.yml | 8 ++++---- .github/workflows/tests.yml | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/actions/downstream-test/action.yml b/.github/actions/downstream-test/action.yml index 14bc16b..deb8c79 100644 --- a/.github/actions/downstream-test/action.yml +++ b/.github/actions/downstream-test/action.yml @@ -8,10 +8,10 @@ inputs: description: "The package spec to install" default: '."[test]"' required: true - package_download_args: + package_download_extra_args: description: "The arguments used to download the package" required: true - default: "--no-deps --no-binary" + default: "" test_command: description: "The test command" default: "pytest -vv -raXxs --durations 10 --color=yes" @@ -32,7 +32,7 @@ runs: package_name=${{inputs.package_name}} package_spec="${{inputs.package_spec}}" test_command="${{inputs.test_command}}" - package_download_args="${{inputs.package_download_args}}" + package_download_extra_args="${{inputs.package_download_args}}" root=$(pwd) eval "${{inputs.env_values}}" echo "::endgroup::" @@ -48,7 +48,7 @@ runs: echo "::group::Download and extract the sdist" mkdir downstream_test cd downstream_test - pip download ${package_download_args} ${package_name} ${package_name} + pip download ${package_download_extra_args} --no-deps --no-binary ${package_name} ${package_name} mkdir ${package_name} tar xfz *.tar.gz -C ${package_name} --strip-components 1 cd ${package_name} diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index a768528..2fb484b 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -64,7 +64,7 @@ jobs: with: package_name: nbclient package_spec: "nbclient[test] ipykernel" - package_download_args: "--no-deps --no-binary --use-pep517" + package_download_extra_args: "--use-pep517" test_command: "echo 'hello'" extra_test: "pytest --pyargs nbclient" env_values: IPYKERNEL_CELL_NAME=\ From 0400cbe3a3854b952b11acaf9910e3fd215c9d42 Mon Sep 17 00:00:00 2001 From: Steven Silvester Date: Thu, 10 Nov 2022 20:17:02 -0600 Subject: [PATCH 3/3] update readme --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index a6bb98c..bc18c2d 100644 --- a/README.md +++ b/README.md @@ -148,6 +148,8 @@ jobs: env_values: "FIZZ=buzz NAME=snuffy" ``` +To test against a prerelease use `package_download_extra_args: "--pre"`. + ## Test Against Dependency Minimum Version Use this action to test that your minimum dependency version constraints are vaild. Note: you may want to also use the minimum supported version of Python