Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version 0.25.1 breaks JupyterLab CI #227

Closed
krassowski opened this issue Apr 3, 2024 · 8 comments · Fixed by #228
Closed

New version 0.25.1 breaks JupyterLab CI #227

krassowski opened this issue Apr 3, 2024 · 8 comments · Fixed by #228
Labels
bug Something isn't working

Comments

@krassowski
Copy link
Member

https://github.com/jupyterlab/jupyterlab/actions/runs/8538604184/job/23391600562?pr=16078

Install from SDist and Test:

+ uv pip compile pyproject.toml -o /home/runner/constraints.txt
error: failed to read from file `pyproject.toml`
  Caused by: No such file or directory (os error 2)

Test Minimum Versions:

Error: Can't find 'action.yml', 'action.yaml' or 'Dockerfile' for action 'jupyterlab/maintainer-tools/.github/actions/install-minimums@v1'.

Windows (integrity) and Windows (python):

Run .\scripts\ci_install

    Directory: C:\Users\runneradmin

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d----            4/3/[20](https://github.com/jupyterlab/jupyterlab/actions/runs/8538604175/job/23391595403?pr=16078#step:4:21)24 12:24 PM                .jupyter
ERROR: Could not open requirements file: [Errno 2] No such file or directory: '/c/Users/runneradmin/constraints.txt'
Exception: D:\a\jupyterlab\jupyterlab\scripts\ci_install.ps1:12
Line |
  12 |  … TCODE -ne 0) { throw "Command failed. See above errors for details" }
     |                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Command failed. See above errors for details
Error: Process completed with exit code 1.
@krassowski krassowski added the bug Something isn't working label Apr 3, 2024
@krassowski krassowski changed the title New version breaks JupyterLab CI New version 0.25.1 breaks JupyterLab CI Apr 3, 2024
@krassowski
Copy link
Member Author

Looks like caused by #225? CC @blink1073

@trungleduc
Copy link
Member

We get the same error in tljh-repo2docker https://github.com/plasmabio/tljh-repo2docker/actions/runs/8539452202/job/23395055599

@blink1073
Copy link
Contributor

We removed install-minimums, it was marked as deprecated. The replacement is described here.

@blink1073
Copy link
Contributor

As for the constraint error, it is because you aren't checking out the repository before running base setup.

@blink1073
Copy link
Contributor

Ah, which I see is the case for all releaser-related things. I can fix that.

@krassowski
Copy link
Member Author

It looks like the jobs are still failing, do we need to tag the release on GitHub?

@krassowski
Copy link
Member Author

We removed install-minimums, it was marked as deprecated. The replacement is described here.

Thanks!

@krassowski
Copy link
Member Author

In jupyterlab/jupyterlab#16105 I still see Windows tests fail with:

Run .\scripts\ci_install

    Directory: C:\Users\runneradmin

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d----            4/3/[20](https://github.com/jupyterlab/jupyterlab/actions/runs/8540936335/job/23399123724?pr=16105#step:4:21)24  3:01 PM                .jupyter
ERROR: Could not open requirements file: [Errno 2] No such file or directory: '/c/Users/runneradmin/constraints.txt'
Exception: D:\a\jupyterlab\jupyterlab\scripts\ci_install.ps1:12
Line |
  12 |  … TCODE -ne 0) { throw "Command failed. See above errors for details" }
     |                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Command failed. See above errors for details
Error: Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants