-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract MathJaxTypesetter into library #5257
Labels
status:resolved-locked
Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Comments
PS: If there is consensus for this, I'd be happy to do the legwork in a PR. |
Sounds good Vidar, yes, please! |
@blink1073 On both counts (typesetter and materialcolors)? |
Yup! |
Actually it should be both, otherwise apputils has an implicit dependency on application (otherwise there will be missing CSS vars, as e.g. |
lock
bot
added
the
status:resolved-locked
Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
label
Aug 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
status:resolved-locked
Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
It would be nice to be able to import/use the
MathJaxTypesetter
without getting a dependency on@jupyterlab/application
. This could be achieved if the class definition was extracted out from the extension package, into a separate library package.On a similar note, would it be reasonable to move
materialcolors.css
from@jupyterlab/application
to@jupyterlab/apputils
? As far as I can tell from the dependency map at https://jlab.readthedocs.io/en/debug-rtd/extensions_dev.html, this should not add any additional dependencies.The text was updated successfully, but these errors were encountered: