-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Notebook scrolls to heading" test fails subtly #15670
Comments
|
It is related to them after all. For context, this snapshot was updated in #15386 which changed the behaviour from aligning heading to bottom to aligning to the top (i.e. what users were expecting). However, the scrolling logic was not using the per-heading scrolling at the time (due to a bug in heading retrieval) and instead using cell scrolling fallback logic, see: jupyterlab/packages/notebook/src/toc.ts Lines 593 to 616 in 85445cc
Once a fix for GHSA-4m77-cmpx-vjc4 was merged, it also fixed the bug which was leading the execution into the fallback branch. The cell scrolling logic aligns to the cell so it gave us a nice padding above the cell. But there may be multiple headings in a cell. |
Since recent fixes in ToC this test: "Table of Contents scrolling to heading › Notebook scrolls to heading" fails by positioning the heading slightly off:
The text was updated successfully, but these errors were encountered: