-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard Shortcuts roadmap: workshop outcomes for next versions #14240
Comments
@GabrielaVives @HaudinFlorence Thank you very much for organizing the workshop, I think it was useful and productive, doing workshops like this for complex UIUX issues should be considered a best practice. Please let me know if you need any support on implementing minimal changes for 4.0.0, would be happy to contribute if needed. |
@andrii-i I'm glad to hear that is was helpful. For sure, we should do this again. I don't always catch the important UX issues that are discussed so don't hesitate to tag me if ever there is a subject for which you think a workshop would be useful. These methodologies can adapt to different complexities and expected outcomes, so we can use them for pretty much anything where a thread of discussion isn't efficient. |
@GabrielaVives Thanks a lot for this issue gathering the important points raised during the workshop. @andrii-i Thanks for offering some help. I may need some in tuning some of css details (for instance I did not manage to properly tune the padding in the table to ensure more spacing between lines). |
@HaudinFlorence I would be happy to help, let's coordinate on gitter if that works, I just messaged you there (same username, andrii-i) |
Hello. I am making here a short summary concerning the actions items and what is ok in the current version (10 days after the workshop) and what still needs to be done:
About these other minimal features for Jupyter Lab 4.0:
|
@HaudinFlorence @GabrielaVives not sure how critical this is for V1 but I wanted to surface that currently in #14053 if shortcut name is long, the table extends horizontally until it starts pushing out keyboard shortcuts into wrapping. Adjusting flex can make so that shortcut combination would not wrap before the shortcut name (they should probably have the same |
Maybe we should define a maximum length beyond which the label is truncated ? It could be shown in full length on hover for example. |
Problem
This issue reports the outcomes of a workshop that took place on March 16th, 2023.
The keyboard shortcuts are currently displayed in a modal that pops up when the user presses
Ctrl Shift h
. We will call this version the V1.#14053 illustrates the current work that is being done on the V1.
This version has one main user experience issue: the list of shortcuts changes depending on the user's context and this list can be very long, making it difficult for users to quickly find the shortcut(s) they are looking for.
As the technical and design solutions to this problem are multiple and require in-depth conversations, we organised a small workshop to help the community take informed decisions about the best solutions for future versions.
Proposed Solution
The goals of the workshop were to:
The agenda
Participants
@tonyfast
@HaudinFlorence
@andrii-i
@jasongrout
@JasonWeill
@RRosio
Results
All the results listed below can be viewed in the original FigJam whiteboard here.
The brainstorming and affinity clustering outcomes are organised in 3 groups:
The minimal changes selected for JLab 4.0 are listed below:
Additional context
Here is the FigJam whiteboard that we worked on.
You can view every step of the workshop and the outcomes.
The text was updated successfully, but these errors were encountered: