Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jupyterlab-git downloads and ships 4MB of icons it does not need #1392

Closed
krassowski opened this issue Feb 7, 2025 · 0 comments · Fixed by #1393
Closed

jupyterlab-git downloads and ships 4MB of icons it does not need #1392

krassowski opened this issue Feb 7, 2025 · 0 comments · Fixed by #1393
Assignees
@Darshan808
Labels
bug

Comments

@krassowski
Copy link
Member

Description

Reproduce

Open JupyterLab with Network profiler, see download of 4MB of icons

or

Download wheel from PyPI (https://pypi.org/project/jupyterlab-git/#files), see:

Image

Expected behavior

  • We do not ship 4 MB of icons we don't neeed
  • Path imports are enforced for mui icon imports

Context

  • Extension version: 0.50.2
@krassowski krassowski added the bug label Feb 7, 2025
@krassowski krassowski changed the title jupyter-git downloads and ships 4MB of icons it does not need jupyterlab-git downloads and ships 4MB of icons it does not need Feb 7, 2025
@Darshan808 Darshan808 mentioned this issue Feb 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Darshan808 Darshan808

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce Path Imports for MUI Icons Darshan808/jupyterlab-git
2 participants
@krassowski @Darshan808