-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diffing does not work #1294
Comments
I don't have any issue. If you have the chance to try again that will be great. |
I still see this issue, both locally and on binder. Here is the gist: https://gist.github.com/krassowski/847732eb6c16e168fb4c0b16d9706142 Tested with both JupyterLab 4.0.9 and 4.1.0a3 in Chrome 119.0.6045.105 and Firefox 119.0.1. Happens with both files and notebooks. |
This is good: jupyterlab-git/src/commandsAndMenu.tsx Lines 293 to 295 in d152a60
This is the wrong code IMO: jupyterlab-git/src/commandsAndMenu.tsx Lines 1279 to 1281 in d152a60
This may be bad too: Lines 363 to 365 in d152a60
|
Thanks for investigating this one more. Indeed I missed it because I almost never run it at within a repository to test different test repositories locally. I'll push a fix. |
Description
Clicking on "diff" button in the panel does nothing for me. Nor does selecting diff from context menu. This happens on both files and notebooks. There is no error message. Other buttons (open/discard/stage) work well. Clicking nbdime git button shows me a diff correctly.
If it works for you maybe it is a transitive problem on my machine, but in that case error propagation is off.
Context
0.50.0rc0
The text was updated successfully, but these errors were encountered: