Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git_command_timeout_s for allowing >20 seconds for git operations #1250

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Add git_command_timeout_s for allowing >20 seconds for git operations #1250

merged 2 commits into from
Aug 3, 2023

Conversation

mdietz94
Copy link
Contributor

Some large repositories may take more than 20 seconds, especially for the initial git clone. Adds a configuration option to make this configurable.

@welcome
Copy link

welcome bot commented Jun 20, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@github-actions
Copy link

Binder 👈 Launch a Binder on branch mdietz94/jupyterlab-git/patch-1

mdietz94
mdietz94 commented Jun 21, 2023
View reviewed changes
package.json Outdated
@@ -1,218 +1,218 @@
{
"name": "@jupyterlab/git",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is unchanged other than prettier running on it

@mdietz94
Copy link
Contributor Author

mdietz94 commented Jun 21, 2023 •
edited
Loading

I believe this PR passes outside of existing breaks (with respect to the broken link message in the changelog), please let me know if there is anything else I can do to help.

fcollonval
fcollonval requested changes Jun 23, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mdietz94

I have minor suggestions (mainly about the naming) and we should use a float as we can rather than an integer.

Would you mind rebasing your branch too as I fixed the CI error in #1252

jupyterlab_git/git.py Outdated Show resolved Hide resolved
jupyterlab_git/git.py Outdated Show resolved Hide resolved
jupyterlab_git/git.py Outdated Show resolved Hide resolved
jupyterlab_git/git.py Outdated Show resolved Hide resolved
jupyterlab_git/git.py Outdated Show resolved Hide resolved
jupyterlab_git/tests/test_clone.py Outdated Show resolved Hide resolved
jupyterlab_git/tests/test_clone.py Outdated Show resolved Hide resolved
jupyterlab_git/tests/test_clone.py Outdated Show resolved Hide resolved
jupyterlab_git/__init__.py Outdated Show resolved Hide resolved
jupyterlab_git/__init__.py Outdated Show resolved Hide resolved
mdietz94 and others added 2 commits June 24, 2023 15:55
@mdietz94
Add a new config value for git operation timeouts
998f936
@mdietz94 @fcollonval
Apply suggestions from code review
bc880e9 
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
@mdietz94
Copy link
Contributor Author

mdietz94 commented Jun 24, 2023 •
edited
Loading

Thanks! Rebased and applied your comments. Let me know if you need anything else. Also no idea why but I still had to reformat that config file even though I rebased from master.

@mdietz94 mdietz94 requested a review from fcollonval June 24, 2023 20:30
fcollonval
fcollonval approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mdietz94 and sorry for the late review

@fcollonval fcollonval merged commit a49a53a into jupyterlab:main Aug 3, 2023
@welcome
Copy link

welcome bot commented Aug 3, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdietz94 @fcollonval