Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Authentication #22

Open
hoo761 opened this issue Jun 27, 2019 · 2 comments
Open

User Authentication #22

hoo761 opened this issue Jun 27, 2019 · 2 comments
Labels
type:Enhancement New feature or request
Milestone

Comments

@hoo761
Copy link
Contributor

hoo761 commented Jun 27, 2019

Currently users are "signed in" without any authentication. They just give their git username and are able to comment as that user. This can be a problem because any person can use anyone's git username to show up as that person.

Authentication with GitHub or another service will make sure that the person who is commenting or creating threads is actually that person.

@hoo761 hoo761 added this to the Future milestone Jun 27, 2019
@hoo761
Copy link
Contributor Author

hoo761 commented Jun 27, 2019

This will help pave the road for #23 by linking to an external API to help with notifications and mentions.

@ktaletsk
Copy link

ktaletsk commented Aug 1, 2019

Another idea could be linking the username with the JupyterHub id when running through JupyterHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants