Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about changed file should not happen in RTC #226

Closed
davidbrochart opened this issue Dec 21, 2023 · 1 comment · Fixed by #228
Closed

Warning about changed file should not happen in RTC #226

davidbrochart opened this issue Dec 21, 2023 · 1 comment · Fixed by #228
Labels
bug Something isn't working

Comments

@davidbrochart
Copy link
Collaborator

Description

In RTC, the frontend should not warn about a file changed in the backend, this should only happen when RTC is not enabled.
Indeed, in RTC when a file is changed in the backend, it should result in the shared document being cleared and reset to the content of the file (the backend acts as just another peer). But I can sometimes see this:

image

Reproduce

I'm currently testing RTC with a simulated slow network, and I can see this behavior very easily. I also saw it on Binder. But on a local network it is very difficult to trigger.

Expected behavior

This warning should not be shown.

Context

  • Operating System and version: Linux Ubuntu 22.04
  • Browser and version: Firefox 119.0.1
  • JupyterLab version: 4.1.0b0
  • jupyter-collaboration: 2.0.0
@davidbrochart
Copy link
Collaborator Author

This was part of #170.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant