Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jupyterlab-chat==0.7.0 fails in Python 3.9 #134

Closed
dlqqq opened this issue Dec 20, 2024 · 0 comments · Fixed by #136
Closed

jupyterlab-chat==0.7.0 fails in Python 3.9 #134

dlqqq opened this issue Dec 20, 2024 · 0 comments · Fixed by #136
Labels
bug Something isn't working

Comments

@dlqqq
Copy link
Member

dlqqq commented Dec 20, 2024 •
edited
Loading

Description

#119 introduced dataclasses to the API of YChat, just released as v0.7.0. However, the @dataclass decorator is being passed a kw_only argument, which is only available in Python 3.10. This results in jupyterlab-chat and all upstream dependents to fail on Python 3.9 platforms now. See jupyterlab/jupyter-ai#1156 as an example.

Since Python 3.9 won't be dropped until October 2025, we will have to remove the kw_only argument for now.

Recommended action

  • Remove kw_only argument
  • Add minimum Python version (currently 3.9) tests to ensure future PRs don't cause Python version incompatibility. This has already been done in Jupyter AI.
@dlqqq dlqqq added the bug Something isn't working label Dec 20, 2024
@dlqqq dlqqq changed the title jupyterlab-chat fails in Python 3.9 jupyterlab-chat==0.7.0 fails in Python 3.9 Dec 20, 2024
This was referenced Dec 20, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix support for Python 3.9 dlqqq/jupyter-chat
1 participant
@dlqqq