Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve rendering of literal dollar signs in chat #1067

Closed
dlqqq opened this issue Oct 30, 2024 · 1 comment · Fixed by #1068
Closed

Improve rendering of literal dollar signs in chat #1067

dlqqq opened this issue Oct 30, 2024 · 1 comment · Fixed by #1068
Assignees
@dlqqq
Labels
bug Something isn't working

Comments

@dlqqq
Copy link
Member

dlqqq commented Oct 30, 2024

Description

Literal dollar signs are treated as inline TeX delimiters, which results in weird rendering behavior when asking any question pertaining to finance with USD as currency:

Screenshot 2024-10-29 at 5 49 24 PM

Proposed fixes

  • Do not treat $ as an inline TeX delimiter.
  • Update the system prompt template to recommend using \( and \) as inline TeX delimiter.
  • Verify support on latest models from multiple providers.
@dlqqq dlqqq added the bug Something isn't working label Oct 30, 2024
@dlqqq dlqqq self-assigned this Oct 30, 2024
@dlqqq dlqqq mentioned this issue Oct 30, 2024
Merged
@dlqqq
Copy link
Member Author

dlqqq commented Oct 30, 2024

Related to: jupyterlab/jupyterlab#8645

@dlqqq dlqqq mentioned this issue Nov 6, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlqqq dlqqq

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow $ to literally denote quantities of USD in chat dlqqq/jupyter-ai
1 participant
@dlqqq