Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration script: handle versioning with hatch #86

Open
jtpio opened this issue Oct 20, 2022 · 1 comment
Open

Migration script: handle versioning with hatch #86

jtpio opened this issue Oct 20, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@jtpio
Copy link
Member

jtpio commented Oct 20, 2022

Problem

The migration script currently defines some tbump configuration by default:

# Handle versioning with tbump - allows for static versioning and makes
# it easier to use jupyter_releaser.
data["project"]["version"] = current_version
data["project"].pop("dynamic", None)
tbump_table = tool_table.setdefault("tbump", {})
tbump_table["version"] = dict(
current=current_version,
regex=r"""
(?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)((?P<channel>a|b|rc|.dev)(?P<release>\d+))?
""".strip(),
)
tbump_table["git"] = dict(message_template=r"Bump to {new_version}", tag_template=r"v{new_version}")
tbump_table["field"] = [dict(name="channel", default=""), dict(name="release", default="")]
tbump_table["file"] = [
dict(
src="pyproject.toml",
version_template='version = "{major}.{minor}.{patch}{channel}{release}"',
)
]

Proposed Solution

Since hatch supports versioning, it could be interesting to use hatch by default instead.

Additional context

Spotted when using the migration script recently.

@jtpio jtpio added the enhancement New feature or request label Oct 20, 2022
@welcome
Copy link

welcome bot commented Oct 20, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant