Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Fix top-level version in package.json for the releaser #74

Closed
jtpio opened this issue Jul 16, 2021 · 1 comment
Closed

Fix top-level version in package.json for the releaser #74

jtpio opened this issue Jul 16, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@jtpio
Copy link
Member

jtpio commented Jul 16, 2021

Description

The top-level version added in #72 was used mostly as a placeholder so it can be npm pack.

galata/package.json

Line 3 in 7500160

"version": "0.1.0",

However it ended as the version added to the changelog:

image

Reproduce

In the automated changelog entry in #73, it picked up 0.1.0 as the version instead of 3.0.11-3 as specified in the workflow.

Probably we could sync the lerna version with the top-level one in package.json
@jtpio jtpio added the bug Something isn't working label Jul 16, 2021
@fcollonval fcollonval mentioned this issue Aug 30, 2021
Closed
3 tasks
@jtpio
Copy link
Member Author

jtpio commented Aug 30, 2021

With jupyterlab/jupyterlab#10796 Galata will be released along with the other @jupyterlab packages.

@jtpio jtpio closed this as completed Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jtpio