Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running pip install oauthenticator==1.* should include the --upgrade flag - right? #732

Closed
consideRatio opened this issue Oct 25, 2021 · 0 comments · Fixed by #719
Closed
Labels
maintenance priority Issue selected to have a bit higher priority

Comments

@consideRatio
Copy link
Member

consideRatio commented Oct 25, 2021

If we don't pin our dependencies like oauthenticator==0.10.0, but do something like oauthenticator==1.*, then we should pin do --upgrade as well, right?

def ensure_pip_packages(prefix, packages):
"""
Ensure pip packages are installed in the given conda prefix.
"""
abspath = os.path.abspath(prefix)
pip_executable = [os.path.join(abspath, 'bin', 'python'), '-m', 'pip']
utils.run_subprocess(pip_executable + [
'install',
'--no-cache-dir',
] + packages)
fix_permissions(prefix)

conda.ensure_pip_packages(
prefix,
[
"jupyterhub==1.4.0",
"jupyterhub-dummyauthenticator==0.3.1",
"jupyterhub-systemdspawner==0.15",
"jupyterhub-firstuseauthenticator==0.14.1",
"jupyterhub-nativeauthenticator==0.0.7",
"jupyterhub-ldapauthenticator==1.3.0",
"jupyterhub-tmpauthenticator==0.6",
"oauthenticator==0.10.0",
"jupyterhub-idle-culler==1.0",
"chardet==3.0.4",
"git+https://github.com/yuvipanda/jupyterhub-configurator@317759e17c8e48de1b1352b836dac2a230536dba"
],
)

Related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance priority Issue selected to have a bit higher priority
Projects
None yet
1 participant