Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to Python 3.8 #618

Closed
GeorgianaElena opened this issue Oct 7, 2020 · 6 comments
Closed

Default to Python 3.8 #618

GeorgianaElena opened this issue Oct 7, 2020 · 6 comments
Labels
enhancement New feature or request needs-discussion

Comments

@GeorgianaElena
Copy link
Member

Proposed change

Upgrade the Python version for the TLJH user environment to Python 3.8.

Alternative options

We could also upgrade from Ubuntu Bionic to Ubuntu Focal Fossa which comes with Python 3.8 by default. This means that the hub venv will also use Python3.8.

Who would use this feature?

There are some related issues asking about upgrading to Python 3.8 that I found:

Also, upgrading the OS of the server that TLJH runs on, from Ubuntu Bionic to Ubuntu Focal Fossa can lead to trouble as reported here #613.

@GeorgianaElena
Copy link
Member Author

@yuvipanda, what are your thoughts about this? 🐈

@yuvipanda
Copy link
Collaborator

I think we can make a branch for ubuntu 18.04, and stop working on that. And require new installs to be on 20.04, which gives us 3.8 on the venv. This break can also help us do things like switch to conda for the hub environment too, and any other cleanup we might need to make. We won't support upgrades from 18.04 to these, so we can make these breaking changes.

What do you think?

@GeorgianaElena
Copy link
Member Author

This sounds like a very good plan @yuvipanda ❤️
So, the current state of master will become 18.04 branch so that at the end we'll have:

  • master for Ubuntu 20.04
  • 18.04 for ubuntu Bionic?

We just need to make sure we're documenting this very good so that people don't break their installs trying to upgrade from master. Maybe put this info at the begging of the readme.

@yuvipanda
Copy link
Collaborator

@GeorgianaElena yeah, that sounds good! We can also refuse to upgrade if it's a 18.04 instance?

@gozes
Copy link

gozes commented Nov 17, 2020

So is there a way to use 20.04 for new install or is this still a work in progress?

@GeorgianaElena
Copy link
Member Author

Solved by the recent upgrade to Ubuntu 20.04 and conda upgrade 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-discussion
Projects
None yet
Development

No branches or pull requests

3 participants