Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STL and STEP file icons #535

Open
SylvainCorlay opened this issue Oct 24, 2024 · 2 comments
Open

STL and STEP file icons #535

SylvainCorlay opened this issue Oct 24, 2024 · 2 comments
Milestone
3.0.0

Comments

@SylvainCorlay
Copy link
Member

It seems that the file icon is not showing up in the tab title for STL and STEP files.

On a separate note, it would probably make sense to not use the JupyterCAD logo for these file types, but use a different one for each.
@arjxn-py arjxn-py added this to the 3.0.0 milestone Oct 24, 2024
@trungleduc
Copy link
Member

https://www.flaticon.com/free-icon/stl_9811308?term=stl+file&page=1&position=10&origin=search&related_id=9811308
https://www.flaticon.com/free-icon/stp_9811307?term=stp+file&page=1&position=3&origin=search&related_id=9811307

These icons look good

@SylvainCorlay
Copy link
Member Author

Yes, we could have something like this, but reusing the current file icon of JupyterLab for consistency.

Image

@SylvainCorlay SylvainCorlay added enhancement New Feature or improvement and removed enhancement New Feature or improvement labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@SylvainCorlay @trungleduc @arjxn-py