-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching tabs does not update the main view properly #236
Comments
Maybe it is related to the STEP file since it does not happen with 2 JCAD files jcad-11.mp4 |
I see you are not using the main branch but your branch where you have a separate worker implementation. Would you be able to try on the main branch? I also see the issue appear with jcad files BTW |
My first guess is that whenever a DISPLAY_SHAPE message is sent from the worker, all viewers are receiving the message |
ah yes, I was too lazy to switch to main. Maybe we can wait for #230, I'm finishing it soon, and hopefully, this issue can be fixed. |
Indeed this issue has been introduced during the refactor, more precisely this line is causing the issue: https://github.com/jupytercad/jupytercad/blob/0201e9d19d3344fd76550c829b8630beed1db696/python/jupytercad_core/src/plugin.ts#L71 The ID of the worker is now a const string, when it was an id on a per-view basis prior to this change: https://github.com/jupytercad/jupytercad/blob/v0.3.3/packages/jupytercad-extension/src/mainview.tsx#L122 So maybe you'd need to take this into account in your PR #230, if not done already |
it was done already :D |
Screencast.from.2023-12-13.16-59-43.webm
The text was updated successfully, but these errors were encountered: