From 1b9637734d10f145c3226089853cd370b985f4cb Mon Sep 17 00:00:00 2001 From: Ben Thayer Date: Sat, 6 Jun 2020 10:27:24 -0500 Subject: [PATCH] Backspace deletes empty line (#5502) --- notebook/static/notebook/js/codecell.js | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/notebook/static/notebook/js/codecell.js b/notebook/static/notebook/js/codecell.js index 7f035cae8e..f5b21bf8c4 100644 --- a/notebook/static/notebook/js/codecell.js +++ b/notebook/static/notebook/js/codecell.js @@ -64,20 +64,14 @@ define([ } else { // range is cursor var line = cm.getLine(head.line).substring(0, head.ch); - if( line.match(/^\ +$/) !== null){ + if (line.match(/^\ +$/) !== null){ // delete tabs var prevTabStop = (Math.ceil(head.ch/tabSize)-1)*tabSize; - var from = { - ch: prevTabStop, - line: head.line - }; + var from = CodeMirror.Pos(head.line, prevTabStop) cm.replaceRange("", from, head); } else { - // delete non-tabs - var from = { - ch: head.ch-1, - line: head.line - }; + // delete normally + var from = cm.findPosH(head, -1, 'char', false); cm.replaceRange("", from, head); } }