Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

empty py.test file in notebook/ #6763

Closed
frenzymadness opened this issue Mar 8, 2023 · 2 comments · Fixed by #6764
Closed

empty py.test file in notebook/ #6763

frenzymadness opened this issue Mar 8, 2023 · 2 comments · Fixed by #6764
Labels
bug status:Needs Triage Applied to issues that need triage

Comments

@frenzymadness
Copy link
Contributor

Commit 22475a3 introduced notebook/py.test file and I have no idea why an empty file like that might be needed. What is the purpose of that file?
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Mar 8, 2023
@jtpio
Copy link
Member

jtpio commented Mar 8, 2023

Thanks @frenzymadness for the report.

Not sure it's needed. Would you like to open a PR that removes the file, so we can see if CI still passes? Thanks!

@frenzymadness frenzymadness mentioned this issue Mar 8, 2023
Merged
@frenzymadness
Copy link
Contributor Author

CI is green so I think the file is useless.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug status:Needs Triage Applied to issues that need triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove empty py.test file frenzymadness/notebook
2 participants
@jtpio @frenzymadness