Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nbclassic explicit uninstall on Binder #6547

Closed
jtpio opened this issue Sep 27, 2022 · 0 comments · Fixed by #6548
Closed

Remove nbclassic explicit uninstall on Binder #6547

jtpio opened this issue Sep 27, 2022 · 0 comments · Fixed by #6548
Labels
maintenance
Milestone
7.0

Comments

@jtpio
Copy link
Member

jtpio commented Sep 27, 2022

#6505 explicitly uninstalls nbclassic on Binder as it would otherwise shadow the Notebook 7 endpoint:

notebook/binder/postBuild

Lines 6 to 8 in 7364633

# TODO: remove when it's possible to install nbclassic next to Notebook v7
# without nbclassic shadowing the v7 endpoints
python -m pip uninstall nbclassic -y

We should try removing this when a new release of nbclassic is out with this fix: jupyter/nbclassic#141
@jtpio jtpio added this to the 7.0 milestone Sep 27, 2022
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Sep 27, 2022
@jtpio jtpio changed the title Remove nbclassic explicit uninsall on Binder Remove nbclassic explicit uninstall on Binder Sep 27, 2022
@jtpio jtpio mentioned this issue Sep 27, 2022
Merged
@jtpio jtpio added maintenance and removed status:Needs Triage Applied to issues that need triage labels Sep 27, 2022
@jtpio jtpio mentioned this issue Sep 29, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
7.0
Development

Successfully merging a pull request may close this issue.

Remove the nbclassic explicit uninstall on Binder jtpio/notebook
1 participant
@jtpio