Disable keyboard shortcuts when entring text in create shortcut menu

[matsievskiysv]

In version 5.1.0 of notebook when entering keyboard shortcut menu from Help->Keyboard shortcuts->Edit shortcuts global shortcuts are not disabled.
For example, if I want to type Ctrl-Enter I would get only Ct-Ente because r and l are binded to the jupyter commands.

[takluyver]

It appears to be working correctly for me. What browser are you using? Can you describe exactly what sequence of clicks does this?

[matsievskiysv]

I experience the same behavior on firefox nightly 58.0a1, surf 2.0 and ungoogled-chromium 58.
Exact key sequence is described in my previous message.
Note, that the same menu, accessed through Help->Edit Keyboard Shortcuts works fine.

[takluyver]

Ah, now I see it. Sorry, I skim read and was going to it directly from the help menu.

[takluyver]

Here's the relevant code:

notebook/notebook/static/notebook/js/quickhelp.js

Lines 285 to 291 in 12592ef

	.click(function () {
	// close this dialog
	$(that.shortcut_dialog).modal("toggle");
	// and open the next one
	that.keyboard_manager.actions.call(
	'jupyter-notebook:edit-command-mode-keyboard-shortcuts');
	});

When a dialog opens, it disables our shortcuts, and when it closes, it re-enables them. But for some reason, the event from closing the first dialog fires after the event from opening the second one. So the shortcuts get re-enabled by the first dialog closing, even though another one is still open.

@Carreau @gnestor any ideas how to avoid that?

[Carreau]

@Carreau @gnestor any ideas how to avoid that?

Not exactly sure; we should try to have a stack-based disablig / refcounting, but that might lead to other bugs.

[gnestor]

This seems to work for me:

$(that.shortcut_dialog).on('hidden.bs.modal', function (e) {
    that.keyboard_manager.actions.call(
        'jupyter-notebook:edit-command-mode-keyboard-shortcuts'
    );
});

[takluyver]

Thanks @gnestor