Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to authenticate API endpoints should raise 403 instead of redirect #2428

Closed
minrk opened this issue Apr 19, 2017 · 4 comments
Closed

Failure to authenticate API endpoints should raise 403 instead of redirect #2428

minrk opened this issue Apr 19, 2017 · 4 comments

Comments

@minrk
Copy link
Member

minrk commented Apr 19, 2017

Tornado's @web.authenticated redirects to login_url on failed authentication, but this isn't appropriate for the REST API. We should be raising a simple 403 instead of redirecting.
@edmundhenley-mo
Copy link

Hi @minrk - found this when digging into jupyter/nbdime#749.
In case useful (sorry for noise if not!), has this been superseded by jupyter-server/jupyter_server#1392 ?

@minrk
Copy link
Member Author

minrk commented Mar 13, 2024

I think it hasn't, but it does get part way there.

@minrk
Copy link
Member Author

minrk commented Mar 13, 2024

Migrating to jupyter-server!

@minrk
Copy link
Member Author

minrk commented Mar 13, 2024

ha, this was fixed by #2853 ... 7 years ago.

@minrk minrk closed this as completed Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@minrk @edmundhenley-mo