Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splitting a slide cell results in one non-slide cell and one slide cell #2273

Closed
parmentelat opened this issue Mar 10, 2017 · 5 comments · Fixed by #2349
Closed

splitting a slide cell results in one non-slide cell and one slide cell #2273

parmentelat opened this issue Mar 10, 2017 · 5 comments · Fixed by #2349

Comments

@parmentelat
Copy link
Contributor

After using 'split cell' in the middle of a cell marked as 'slide', what I end up with is

  • a first cell not marked as slide
  • and a second cell marked* as slide

I would expect it the other way around; but maybe that's just me ?

I'm using 'jupyter notebook' with jupyter-4.3.0 on macos

@takluyver
Copy link
Member

Pinging @damianavila who's probably interested.

@parmentelat
Copy link
Contributor Author

parmentelat commented Mar 17, 2017

I just witnessed that the same behaviour happens with a cell marked as 'split', so it suggests it's the complete metadata that gets attached to the second cell rather than to the first.

Trying to setp back a little, I would see 3 policies here

  1. either we decide statically that the metadata should be duplicated; not optimal but at least simple to grasp
  2. or we arbitrarily choose one the 2 resulting slides as the recipient for the whole package; my conjecture is that's what is done now, and the recipient is the second
  3. or we decide it's more complicated and cannot be done while ignoring the various semantics; arguing that e.g. the slide tag probably is better attached to cell (a), while split cell should be copied to (a) and (b)

Of course 3. is clearly a pandorra box; maybe giving a try at option 1. would make sense...

Just thinking aloud here, it's not really a big deal

@takluyver
Copy link
Member

Your conjecture is correct - splitting works by inserting a new cell above, and moving some of the text to it. Here's the code. I agree that copying the metadata is probably a more reasonable approach.

@parmentelat
Copy link
Contributor Author

parmentelat commented Mar 21, 2017 via email

@damianavila
Copy link
Member

I agree that copying the metadata is probably a more reasonable approach.

I agree as well.

@minrk minrk added this to the 5.1 milestone Apr 5, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants