Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.4.1 Release #929

Closed
MSeal opened this issue Dec 10, 2018 · 9 comments
Closed

5.4.1 Release #929

MSeal opened this issue Dec 10, 2018 · 9 comments

Comments

@MSeal
Copy link
Contributor

MSeal commented Dec 10, 2018

What PR's should we get in before a patch release would be reasonable to ship? We've had requests for a few changes to get out that already merged.

I would like to get #905 merged, but it's not mandatory if people would rather that be a 5.5 change.

Thoughts / Requests?

@mgeier
Copy link
Contributor

mgeier commented Dec 16, 2018

What about making a quick release before the end of the year without any additional changes (since there don't seem to be urgent requests)?

The nbconvert project seems to quite inactive right now, probably there is some more progress next year?

@MSeal
Copy link
Contributor Author

MSeal commented Dec 16, 2018

I'll definitely get the release rolling before the new year. Was talking offline about it some and you're right that it'll probably just cut what's there now.

@mgeier
Copy link
Contributor

mgeier commented Feb 4, 2019

I don't mean to appear impatient, but what about this release?

@MSeal
Copy link
Contributor Author

MSeal commented Feb 5, 2019

Sorry, you're right to be impatient. My apologies for being late with other tasks. We have a summit we're running this week but I'll get the process going at the end of the week. It sounds like there wasn't any push for other changes and some of the pending changes look to not being moved forward for a bit so I won't block on them.

@MSeal
Copy link
Contributor Author

MSeal commented Feb 8, 2019

5.4.1 is live -- apologies for the delay again.

@MSeal MSeal closed this as completed Feb 8, 2019
@astrojuanlu
Copy link

Thanks @MSeal!

@astrojuanlu
Copy link

...Although the release that has been uploaded to PyPI is 5.4.1.dev0, I believe? https://pypi.org/project/nbconvert/#history

@MSeal
Copy link
Contributor Author

MSeal commented Feb 9, 2019

Oops. Fixing

@mgeier
Copy link
Contributor

mgeier commented Feb 10, 2019

Thanks a lot @MSeal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants