-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown/HTML images not displaying #89
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
I'm having the same issue with nbclassic-0.4.3 for local images. It works for remote images ( |
Hmm, I can work around this by prepending $ jupyter --version
Selected Jupyter core packages...
IPython : 7.31.1
ipykernel : 6.4.2
ipywidgets : 7.7.1
jupyter_client : 7.3.4
jupyter_core : 4.11.1
jupyter_server : 1.18.1
jupyterlab : 3.4.4
nbclient : 0.5.13
nbconvert : 6.5.0
nbformat : 5.4.0
notebook : 6.4.12
qtconsole : 5.2.2
traitlets : 5.1.1 |
This is quite disruptive when publishing notebooks via jupyter-book because the extra I'm tied to nbclassic when presenting in class because I use the RISE extension, but I also publish as a website using jupyter-book. Or maybe @choldgraf has a tip to get jupyter-book to do this path substitution as a work-around until this nbclassic issue is resolved? |
This is likely to be fixed in #148. |
Thanks! I can confirm local images work as expected after |
Working for me as well! Thanks! |
Closing based on previous positive reports. Thx all. |
Description
When using nbclassic (0.3.5 tested, others may be affected) images in notebooks made with Markdown (
![](logo.png)
) and HTML (<img src="logo.png">
) do not work. Markdown images show a blank cell and HTML images show a broken image icon. Clicking on the image and "Open image in New Tab" directs to "/edit/logo.png". This same bug was reported in the jupyter/notebook repo (jupyter/notebook#6267), but through some debugging I believe it is an nbclassic issue. I have been able to reproduce the issue running the container itself locally and on JupyterHub.Reproduce
docker run -it -p 8888:8888 -p 8889:8889 jupyter/minimal-notebook:2022-01-12
. I mapped two ports because I used the terminal in Jupyter to runjupyter nbclassic
.jupyter nbclassic
.!wget -O logo.png cybergisx.cigi.illinois.edu/hub/logo
.![](logo.png)
or<img src="logo.png">
.We had this issue when we upgraded our JupyterHub (https://cybergisx.cigi.illinois.edu/) and debugged it through a lot of trial and error.
Expected behavior
I expect the images to display just as they do in jupyter/notebook. The image below shows the result from the reproduce procedure with notebook on the left and nbclassic on the right, both displaying the same notebook:
Context
Troubleshoot Output
Command Line Output
The text was updated successfully, but these errors were encountered: