Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace urljoin with url_path_join in extensionapp #304

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Sep 8, 2020

This fixes a bug when serving static content behind a base_url. urljoin drops the base_url because of its leading forward slash. Switching to using url_path_join from our utils module.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blink1073 blink1073 merged commit ecf1959 into jupyter-server:master Sep 8, 2020
@blink1073
Copy link
Contributor

Released as jupyter_server-1.0.0rc16.

@blink1073 blink1073 added this to the 1.0 Release milestone Sep 17, 2020
Zsailer pushed a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
replace urljoin with url_path_join in extensionapp
@Zsailer Zsailer deleted the urljoin branch January 16, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants