Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic login.html template #220

Merged
merged 1 commit into from
May 5, 2020
Merged

Conversation

Mistobaan
Copy link
Contributor

If you try to run a jupyter-server with just basic password it will fail with 500 on the login handler with the error "login.html" not found.

This PR fixes the error. The code is extracted from jupyter-notebook login.html

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Mistobaan! This is great!

A couple of things...

  1. Do you mind migrating the logout.html template here too?
  2. Let's drop the class attributes from all HTML tags, since we're not going to style any of these templates from Jupyter Server. Those tags are specific to the Jupyter Notebook frontend.

jupyter_server/templates/login.html Outdated Show resolved Hide resolved
jupyter_server/templates/login.html Outdated Show resolved Hide resolved
jupyter_server/templates/login.html Outdated Show resolved Hide resolved
@Mistobaan
Copy link
Contributor Author

@Zsailer done also added missing message output that I just noticed on the logout page.

@Zsailer
Copy link
Member

Zsailer commented May 5, 2020

Fantastic! Thanks, @Mistobaan.

@Zsailer Zsailer merged commit 6d909ca into jupyter-server:master May 5, 2020
@blink1073 blink1073 added this to the 1.0 Release milestone Sep 17, 2020
Zsailer pushed a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants