-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simple extension example #117
Conversation
Wow! Thanks, @echarles. This is awesome! I'll review this more closely after the meeting today. |
examples/simple/README.md
Outdated
|
||
## TO FIX | ||
|
||
+ The token created in `browser-open.html` is `None` - http://localhost:8888/?token=None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed in #115
Overall, this looks really good. Thanks, @echarles! I think it would be interesting to add a simple Javascript file that lives behind the This repo by @markellekelly is another great example. This repo includes an example of how to leverage the |
@Zsailer Thx for your review. I have a few ideas to refactor a bit. Also, if ok with @markellekelly, I will inject here the work mark has done to showcase the static_url and typescript example. |
@Zsailer just pushed the typescript example. This is still WIP but you can always scan and give me feedback. One question that was asked yesterday during the server meeting and one info you gave is related to a server which would have multiple extensions (eg. jlab, voila, notebook combined in one server) - I don't see how this is possible: this would mean creating a application with would combine the different handlers, but what about the static content place? We only have a single place for content... |
Each extension should serve its static files behind
In practice, it looks like this:
|
I get that, but a server is launched with Could you write the updates to this example to get multiple extensions (maybe in init:py_ )? |
Ah, yes! Remember that One way to test this directly is by calling:
Or you can enable them automatically in the |
An A key point here is that the ExtensionApp itself is not a server. Rather, it creates an instance of a Jupyter Server and extends it (along with other extensions if they are enabled). Does that make sense? |
Thx Zack. The example has now 2 apps and brings to me more clarity on how the extensions are working. I may bring more fine-tuning but this PR can already be reviewed. |
examples/simple/etc/jupyter/jupyter_server_config.d/simple_ext.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good, @echarles. Left a few comments inline. Let me know when you reach the point for final review.
@Zsailer Just pushed changes that implements your comments - I was also considering moving Makefile to README which is must didactic for an example case. I can take additional comments. To me, this is ready for review/merge. |
Current issues:
Waiting a bit on @Zsailer feedback before opening separated issues for these. |
Thanks, @echarles. Apologies for the delay.
Hm, try adding
This looks like the issue is in the Feel free to open an issue/PR to fix this if you'd like.
This is a bug. The following lines need to be removed from the Feel free to open an issue/PR to fix this if you'd like. |
Thx @Zsailer Adding an |
#172 is created to fix the |
@Zsailer I have removed from |
@Zsailer Would be great to merge this. It can be very useful to test simple extensions and show users how to develop. It will not hurt anything as the example folder is in is own island. |
simple extension example
This is a simple example of a server extension.