Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Generating new user for token-authenticated request keeps appearing when token auth is disabled #1892

Closed
ahlag opened this issue Mar 25, 2023 · 5 comments
Labels
tag:Upstream A problem with one of the upstream packages installed in the docker images type:Bug A problem with the definition of one of the docker images maintained here

Comments

@ahlag
Copy link

ahlag commented Mar 25, 2023

What docker image(s) are you using?

pyspark-notebook

Host OS system and architecture running docker image

MacOS

What Docker command are you running?

Running these with docker compose - docker compose up.

version: '3'
services:
  jupyter:
    image: jupyter/pyspark-notebook
    ports:
      - "8888:8888"
    volumes:
      - ./notebooks:/home/jovyan/work/notebooks
    command: "start.sh jupyter lab --NotebookApp.token='' --NotebookApp.password=''"
    networks:
      - network

networks:
  network:
    name: network

How to Reproduce the problem?

  1. Run docker compose up in the directory that has the above yaml.

Command output

Connecting to kernel e9c0749c-006d-4e25-bc82-77cbf5dc9d0c.
Connecting to kernel e9c0749c-006d-4e25-bc82-77cbf5dc9d0c.
Connecting to kernel e9c0749c-006d-4e25-bc82-77cbf5dc9d0c.
Generating new user for token-authenticated request: 7b68a45cafb241cca9084ff2f8f01622
Generating new user for token-authenticated request: 691150522f9d472abc41be4d553229bd
Generating new user for token-authenticated request: 96bc5cde3369469a8c0d304f2ca34c1e


### Expected behavior

We do not want Generating new user for token-authenticated request: 96bc5cde3369469a8c0d304f2ca34c1e to appear.

### Actual behavior

Generating new user for token-authenticated request: keeps appearing.

### Anything else?

_No response_

### Latest Docker version

- [X] I've updated my Docker version to the latest available, and the issue still persists
@ahlag ahlag added the type:Bug A problem with the definition of one of the docker images maintained here label Mar 25, 2023
@mathbunnyru
Copy link
Member

mathbunnyru commented Mar 25, 2023

@ahlag could you please check, that you have this problem if you don't use our docker images? (just run jupyter lab on the host machine)
If you still have the problem, it would be better to create an issue in the upstream project.
I've also found where this line comes from: https://github.com/jupyter-server/jupyter_server/blob/main/jupyter_server/auth/identity.py#L478

It also might be an expected behaviour, I'm not sure about this.

@ahlag
Copy link
Author

ahlag commented Mar 25, 2023

@mathbunnyru Yes, I was able to replicate this on jupyterlab. Is there a way to mute the logs coming from the docker container?

@100kimch
Copy link

100kimch commented Apr 9, 2023

@mathbunnyru I found this problem too when I use image jupyter/datascience-notebook.

When I build custom image based on jupyter/datascience-notebook, I use this:

FROM jupyter/datascience-notebook:latest

...

ENV JUPYTER_TOKEN=${TOKEN}

@mathbunnyru mathbunnyru added the tag:Upstream A problem with one of the upstream packages installed in the docker images label Apr 9, 2023
@mathbunnyru
Copy link
Member

I'm closing this issue because the original problem is in upstream here: microsoft/vscode-jupyter#13345
Please, use this issue, if you have additional information/thoughts.

The workaround can be found here: jupyter-server/jupyter_server#1245 (comment)

@mathbunnyru mathbunnyru closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2023
@mathbunnyru
Copy link
Member

mathbunnyru commented Jul 20, 2023

This seems to be fixed in the upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:Upstream A problem with one of the upstream packages installed in the docker images type:Bug A problem with the definition of one of the docker images maintained here
Projects
None yet
Development

No branches or pull requests

3 participants