Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of Publishing to GitHub Packages #1264

Closed
THargreaves opened this issue Apr 9, 2021 · 7 comments
Closed

Possibility of Publishing to GitHub Packages #1264

THargreaves opened this issue Apr 9, 2021 · 7 comments
Labels
status:Need Info We believe we need more information about an issue from the reporting user to help, debug, fix type:Enhancement A proposed enhancement to the docker images type:Maintenance A proposed enhancement to how we maintain this project

Comments

@THargreaves
Copy link

There would be considerable benefits to having the Jupyter Docker Stacks publish to GitHub Package Repository as well as DockerHub. This allows considerably faster caching than can be achieved via other means.

Are there plans to implement this? Is there anything preventing this?

@romainx
Copy link
Collaborator

romainx commented Apr 11, 2021

Hello @THargreaves.

To be honest I'm not familiar with GitHub Package Repository and its policy regarding open source projects. Would we be able to store all stacks built here for free?

I don't know neither if there is a global strategy at Jupyter organization level to stick to DockerHub and / or to provide an alternative.

Sorry I'm not a big help, but it could make sense, if you or someone else has more information, do not hesitate.

Best.

@THargreaves
Copy link
Author

THargreaves commented Apr 11, 2021

No worries. Yes, GPR is free for public repositories.

As far as I am aware, the process for pushing to GPR is exactly the same as DockerHub but specifying ghcr.io when logging in, tagging, and pushing.

E.g. here is the introductory Docker example provided by GitHub

echo $PAT | docker login ghcr.io --username phanatic --password-stdin
docker tag app ghcr.io/phanatic/app:1.0.0
docker push ghcr.io/phanatic/app:1.0.0

@mathbunnyru
Copy link
Member

For me, the main question is - do we really need faster caching?
Right now, I don't think that is the case.
At the same time, there is a growing interest in images for other architectures, so the complexity might raise significantly.

@romainx
Copy link
Collaborator

romainx commented Apr 12, 2021

@mathbunnyru good point we have prototyped that building multi-arch image is not sustainable with the current build solution. There is an open issue for that #1203 that could benefit from this solution.

@mathbunnyru mathbunnyru added type:Enhancement A proposed enhancement to the docker images type:Maintenance A proposed enhancement to how we maintain this project labels May 6, 2021
@mathbunnyru
Copy link
Member

@THargreaves are you still interested in publishing images to GitHub Packages?
I don't think we need caching, because currently build system works well.

@mathbunnyru mathbunnyru added the status:Need Info We believe we need more information about an issue from the reporting user to help, debug, fix label Sep 30, 2022
@THargreaves
Copy link
Author

This is not something I am personally interested in or have the time to look into anymore.

@mathbunnyru
Copy link
Member

Then, I guess, we can close this issue.

@mathbunnyru mathbunnyru closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:Need Info We believe we need more information about an issue from the reporting user to help, debug, fix type:Enhancement A proposed enhancement to the docker images type:Maintenance A proposed enhancement to how we maintain this project
Projects
None yet
Development

No branches or pull requests

3 participants