Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Use ConfigManager during setup.py, not hack to add line to .py config file #156

Closed
parente opened this issue Dec 16, 2015 · 1 comment
Closed

Comments

@parente
Copy link
Member

parente commented Dec 16, 2015

Here's the dashboards PR jupyter/dashboards#156 that removed the hack. Unfortunately, this switch breaks compatibility with declarative widgets unless they too are added to the JSON config file. Otherwise, notebook says:

[W 02:43:26.010 NotebookApp] Collisions detected in jupyter_notebook_config.py and jupyter_notebook_config.json config files. jupyter_notebook_config.json has higher priority: {
      "NotebookApp": {
        "server_extensions": "<traitlets.config.loader.LazyConfigValue object at 0x7f5dfc0c7f60> ignored, using ['urth.dashboard.nbexts']"
      }
    }

For the time being, I've reverted the fix in the 0.2.x branch of dashboards to retain compatibility but have left the change in dashboards master. We're going to need to change in lock step for this to work.

Source: https://github.com/Anaconda-Server/nbsetuptools

@lbustelo
Copy link
Collaborator

Fixing #165 will include this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants