Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test / JavaScript build failing on all PRs #3651

Open
kellietay opened this issue Dec 13, 2022 · 5 comments
Open

Test / JavaScript build failing on all PRs #3651

kellietay opened this issue Dec 13, 2022 · 5 comments
Assignees

Comments

@kellietay
Copy link

kellietay commented Dec 13, 2022

Description

Test / JavaScript is failing in the build on all PRs.

image

The issue seems to be related to FirefoxHeadless
image

Reproduce

  1. Go to any PR (e.g. Fix unintentional deprecation warnings #3650)
  2. Scroll down to see the checks/tests and you can see the failure

Expected Behaviour

This was working previously, for example in #3638
image

@kellietay kellietay self-assigned this Dec 13, 2022
@bollwyvl
Copy link
Contributor

bollwyvl commented Dec 18, 2022

This may be related to ipython/ipykernel#1059. A quick way to see might be to pin to ipykernel !=6.19.*, which i may do in #3653 if it demonstrates the condition described here.

Update: it looks like it's pulling ipykernel-6.16.2 in that failing, so this is apparently not the problem.

@bollwyvl
Copy link
Contributor

The above comment is probably not the case, as we got a couple more releases out, and no improvement.

Along the way, jupyter_server 2.0.2 independently broke some other stuff.

Ideally, moving #3566 forward would be the win, as there's really quite a lot of drift, some of which i explored on some rolled back commits in #3653. Even getting some of the formatters and version bumping tools would help.

@bollwyvl
Copy link
Contributor

Here's the fix:

and the proof:

If it helps get #3653 merged, I'm happy to do a separate PR.

@maartenbreddels
Copy link
Member

Fixed in #3653
Thanks for the report @kellietay, and thanks for digging into this @bollwyvl

@bollwyvl
Copy link
Contributor

Maybe fixed more in #3673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants