From 028feb026e00863064122229adfe905319234400 Mon Sep 17 00:00:00 2001 From: "Afshin T. Darian" Date: Thu, 21 Jan 2021 16:15:29 +0000 Subject: [PATCH] Re-enable default_url in ExtensionApp --- jupyter_server/extension/application.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/jupyter_server/extension/application.py b/jupyter_server/extension/application.py index 5720d9cfed..21294e59eb 100644 --- a/jupyter_server/extension/application.py +++ b/jupyter_server/extension/application.py @@ -180,6 +180,12 @@ def get_extension_point(cls): # Extension URL sets the default landing page for this extension. extension_url = "/" + default_url = Unicode().tag(config=True) + + @default('default_url') + def _default_url(self): + return self.extension_url + # Extension can configure the ServerApp from the command-line classes = [ ServerApp, @@ -332,7 +338,6 @@ def _jupyter_server_config(cls): base_config = { "ServerApp": { "jpserver_extensions": {cls.get_extension_package(): True}, - "default_url": cls.extension_url } } base_config["ServerApp"].update(cls.serverapp_config) @@ -438,6 +443,9 @@ def _load_jupyter_server_extension(cls, serverapp): if cls._is_starter_app: serverapp._starter_app = extension extension.initialize() + # Set the serverapp's default url to the extension's url. + if cls._is_starter_app: + serverapp.default_url = extension.default_url return extension @classmethod